From fda535921eb0f7c56d5c90c8119fb3a95ee3fe68 Mon Sep 17 00:00:00 2001 From: Lei Wang Date: Wed, 24 Jun 2020 22:38:40 -0700 Subject: [PATCH 1/3] Add semantic conventions for container id --- CHANGELOG.md | 1 + specification/resource/semantic_conventions/README.md | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e64dd46573..30856c22175 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ the release. - Extend semantic conventions for RPC and allow non-gRPC calls ([#604](https://github.com/open-telemetry/opentelemetry-specification/pull/604)) - Add span attribute to indicate cold starts of Function as a Service executions ([#650](https://github.com/open-telemetry/opentelemetry-specification/pull/650)) - Added conventions for naming of exporter packages +- Add semantic conventions for container id - Clarify Tracer vs TracerProvider in tracing API and SDK spec. Most importantly: * Configuration should be stored not per Tracer but in the TracerProvider. * Active spans are not per Tracer. diff --git a/specification/resource/semantic_conventions/README.md b/specification/resource/semantic_conventions/README.md index 0d23cd0cbd5..3341d974e23 100644 --- a/specification/resource/semantic_conventions/README.md +++ b/specification/resource/semantic_conventions/README.md @@ -92,6 +92,7 @@ Attributes defining a compute unit (e.g. Container, Process, Function as a Servi | Attribute | Description | Example | |---|---|---| | container.name | Container name. | `opentelemetry-autoconf` | +| container.id | Container id. | `a3bf90e006b2` | | container.image.name | Name of the image the container was built on. | `gcr.io/opentelemetry/operator` | | container.image.tag | Container image tag. | `0.1` | From 2eaddaffbf17f98be4dc1c4079d8d579b292efbf Mon Sep 17 00:00:00 2001 From: Lei Wang <66336933+wangzlei@users.noreply.github.com> Date: Mon, 29 Jun 2020 11:33:46 -0700 Subject: [PATCH 2/3] Update specification/resource/semantic_conventions/README.md Co-authored-by: Armin Ruech --- specification/resource/semantic_conventions/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/resource/semantic_conventions/README.md b/specification/resource/semantic_conventions/README.md index 3341d974e23..fb1e967492d 100644 --- a/specification/resource/semantic_conventions/README.md +++ b/specification/resource/semantic_conventions/README.md @@ -92,7 +92,7 @@ Attributes defining a compute unit (e.g. Container, Process, Function as a Servi | Attribute | Description | Example | |---|---|---| | container.name | Container name. | `opentelemetry-autoconf` | -| container.id | Container id. | `a3bf90e006b2` | +| container.id | Container id. Usually a UUID, as for example used to [identify Docker containers][]. The UUID might be abbreviated. | `a3bf90e006b2` | | container.image.name | Name of the image the container was built on. | `gcr.io/opentelemetry/operator` | | container.image.tag | Container image tag. | `0.1` | From 16068c74bfc95580e211aeb730d70e24a57ed3a7 Mon Sep 17 00:00:00 2001 From: Lei Wang <66336933+wangzlei@users.noreply.github.com> Date: Mon, 29 Jun 2020 11:33:55 -0700 Subject: [PATCH 3/3] Update specification/resource/semantic_conventions/README.md Co-authored-by: Armin Ruech --- specification/resource/semantic_conventions/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/resource/semantic_conventions/README.md b/specification/resource/semantic_conventions/README.md index fb1e967492d..6e8b994a868 100644 --- a/specification/resource/semantic_conventions/README.md +++ b/specification/resource/semantic_conventions/README.md @@ -96,6 +96,7 @@ Attributes defining a compute unit (e.g. Container, Process, Function as a Servi | container.image.name | Name of the image the container was built on. | `gcr.io/opentelemetry/operator` | | container.image.tag | Container image tag. | `0.1` | +[identify Docker containers]: https://docs.docker.com/engine/reference/run/#container-identification ### Function as a Service **type:** `faas`