Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JSON in two other languages to ensure we are satisfied. #2797

Closed
Tracked by #1957
tigrannajaryan opened this issue Sep 13, 2022 · 6 comments
Closed
Tracked by #1957
Assignees

Comments

@tigrannajaryan
Copy link
Member

No description provided.

@tigrannajaryan
Copy link
Member Author

I believe we have an implementation in Go (in the Collector) and in JavaScript (@dyladan can you please confirm?).

@dyladan
Copy link
Member

dyladan commented Sep 13, 2022

Yes and I believe JS is the only language implementation

@tigrannajaryan
Copy link
Member Author

Do we feel the need to implement it in one more language? In the Collector we have Go implementation of the OTLP/JSON receiver and exporter.

@dyladan
Copy link
Member

dyladan commented Sep 13, 2022

only if we feel it would be useful. it's important for JS due to constraints on the runtime and on package size. this may also be of interest to android/ios where distributing protobuf/grpc may be unwanted bloat on the package? Possibly also for c/cpp where it may see use in embedded systems or similar restricted environments.

@jack-berg
Copy link
Member

In java we don't have an OTLP http/json protocol exporter, but we do have logging exporters which log in OTLP json format. The protocol part is pretty much the same with http/protobuf and http/json, so it should really just be the encoding that we're trying to increase confidence in. And java does have artifacts which produce the json encoding.

@tigrannajaryan
Copy link
Member Author

I am going to close, but if anyone thinks we do need more implementations please feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants