From 66f8c4c884d75ed3882af4f31ab036271bdd2a94 Mon Sep 17 00:00:00 2001 From: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com> Date: Fri, 3 Mar 2023 18:59:56 +0200 Subject: [PATCH] Expand pool.name in semantic conventions (#3050) according to the discussion here: https://github.com/open-telemetry/opentelemetry-specification/issues/3038 I'm updating the `pool.name attribute` --- CHANGELOG.md | 2 ++ specification/metrics/semantic_conventions/database-metrics.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ace1f31c4c4..bc67a08e058 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -159,6 +159,8 @@ release. - Rename built-in ExemplarFilters to AlwaysOn, AlwaysOff and TraceBased. ([#2919](https://github.com/open-telemetry/opentelemetry-specification/pull/2919)) +- Expand the declaration of `pool.name`. + ([#3050](https://github.com/open-telemetry/opentelemetry-specification/pull/3050)) - Add `MaxScale` config option to Exponential Bucket Histogram Aggregation. ([#3017](https://github.com/open-telemetry/opentelemetry-specification/pull/3017)) - Rename exponential bucket histogram aggregation to base 2 exponential histogram diff --git a/specification/metrics/semantic_conventions/database-metrics.md b/specification/metrics/semantic_conventions/database-metrics.md index 6b34a5424f1..82b4a564e67 100644 --- a/specification/metrics/semantic_conventions/database-metrics.md +++ b/specification/metrics/semantic_conventions/database-metrics.md @@ -58,4 +58,4 @@ Below is a table of the attributes that MUST be included on all connection pool | Name | Type | Description | Examples | Requirement Level | |-------------|--------|------------------------------------------------------------------------------|----------------|-------------------| -| `pool.name` | string | The name of the connection pool; unique within the instrumented application. | `myDataSource` | Required | +| `pool.name` | string | The name of the connection pool; unique within the instrumented application. In case the connection pool implementation does not provide a name, then the [db.connection_string](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#connection-level-attributes) should be used. | `myDataSource` | Required |