Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis attributes not aligned with latest semantic conventions #2885

Open
luke6Lh43 opened this issue Sep 24, 2024 · 1 comment
Open

Redis attributes not aligned with latest semantic conventions #2885

luke6Lh43 opened this issue Sep 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@luke6Lh43
Copy link
Contributor

Describe your environment

OS: macOS Sequoia
Architecture: x86_64 (Intel processor)
Python: 3.12.5

opentelemetry-api==1.27.0
opentelemetry-distro==0.48b0
opentelemetry-exporter-otlp==1.27.0
opentelemetry-exporter-otlp-proto-common==1.27.0
opentelemetry-exporter-otlp-proto-grpc==1.27.0
opentelemetry-exporter-otlp-proto-http==1.27.0
opentelemetry-instrumentation==0.48b0
opentelemetry-instrumentation-redis==0.48b0
opentelemetry-proto==1.27.0
opentelemetry-sdk==1.27.0
opentelemetry-semantic-conventions==0.48b0

What happened?

Hello,

I have recently been working on a project that required Redis instrumentation for two different languages. During this process, I noticed some discrepancies in the attributes being collected. To investigate further, I conducted testing to check the attributes collected for Redis instrumentation across six of the most popular languages. I have documented my testing in this GitHub repository:

[Link to GitHub Repo]

What We Capture Today ==> How It Should Look in Latest Semantic Conventions

db.statement: GET ? ==> db.statement: GET ?
db.system: redis ==> db.system: redis
db.redis.database_index: 0 ==> db.namespace: 0
net.peer.name: localhost ==> server.address: localhost
net.peer.port: 6379 ==> network.peer.port: 6379
net.transport: ip_tcp ==> Not sure if it's needed
db.redis.args_length: 2 ==> Not sure if it's needed

The latest OpenTelemetry semantic conventions for Redis can be found here:
OpenTelemetry Semantic Conventions for Redis

Steps to Reproduce

https://github.com/luke6Lh43/otel-redis-testing/blob/main/Readme.md#python

Expected Result

See above

Actual Result

See above

Additional context

No response

Would you like to implement a fix?

None

@luke6Lh43 luke6Lh43 added the bug Something isn't working label Sep 24, 2024
@bourbonkk
Copy link
Contributor

@luke6Lh43
Are you currently working on this �issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants