-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datadog exporter shouldn't parse span description to determine if there was an exception #244
Comments
//cc @majorgreys |
Thanks for reporting this @alertedsnake! Your suggestion makes sense. If you end up tackling this, just give a heads up here and I'll check in before giving it a go myself. |
@owais @majorgreys can you assign this to me? I'll try to address this and bring in line with spec compliane , sorry for the delay |
@ericmustin thanks! I got bogged down trying to fix #262 that I haven't had a chance to look at this one. |
@alertedsnake no worries, only one of us gets time during their day job to do this 🙃 . May ask for a review as my python is quite rusty, will ping on PR |
@ericmustin assigned! |
The Datadog exporter currently parses the status description to determine if an exception was raised, yet the specification requires these to be recorded as events (and the python code already does this), so the Datadog exporter should read this data from the event list instead of hoping the description is properly formatted.
The current code does say that span events are not supported , and while that would suggest that reporting events are not supported, we could certainly parse them for this data.
I'll probably tackle this, I'm already working on #154. Also mentioned in #236, where I worked around the current behavior.
The text was updated successfully, but these errors were encountered: