-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide if version number is needed in *Data and *Request messages #378
Comments
So I think adding version is mostly a defensive strategy, as protobuf/json doesn't have some of the nice backwards-compatibility features that the binary format has, with the most obvious one being the renaming support (see protocolbuffers/protobuf#3949). We recently decided to rename Of course, consumers/parsers can always try to detect features and double (triple) look for existing values (e.g. if Personally I don't expect us to be renaming/changing the proto definitions (too often), but if for whatever reason we really must do it, we will be (somewhat) covered. |
Forgot to mention that during the last call we decided to not add this version field, at leas initially, and we will add it if/when it is needed, so this is not a blocker for making OTLP/JSON stable anymore. |
Per the discussion in the SIG, we will not add initially a version. |
@bogdandrutu was there a new discussion that I missed or you are referring to previous discussions? Also, there is an OTEP open that proposes to add the version number to the request headers: open-telemetry/oteps#204 |
We may want to add a format/protocol version number to messages like LogsData, MetricsData, ExportLogsServiceRequest, etc.
The request is originally coming from open-telemetry/opentelemetry-specification#1957 (comment)
I would like to understand why the version number is necessary in the payload. OTLP spec claims the following:
Adding the version number seems to contradict with this, so we need to explain why this doesn't work.
The text was updated successfully, but these errors were encountered: