From 9562084c127232010e4b1b4036878b01bfd440ea Mon Sep 17 00:00:00 2001 From: Tigran Najaryan Date: Thu, 3 Mar 2022 12:56:14 -0500 Subject: [PATCH] Add message deprecation notice and make deprecated field id=1000 --- opentelemetry/proto/logs/v1/logs.proto | 4 +++- opentelemetry/proto/metrics/v1/metrics.proto | 4 +++- opentelemetry/proto/trace/v1/trace.proto | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/opentelemetry/proto/logs/v1/logs.proto b/opentelemetry/proto/logs/v1/logs.proto index 835c33205..6cbd09ed1 100644 --- a/opentelemetry/proto/logs/v1/logs.proto +++ b/opentelemetry/proto/logs/v1/logs.proto @@ -79,7 +79,7 @@ message ResourceLogs { // scope_logs is not set then the value in instrumentation_library_logs // SHOULD be used instead by converting InstrumentationLibraryLogs into ScopeLogs. // If scope_logs is set then instrumentation_library_logs field SHOULD be ignored. - repeated InstrumentationLibraryLogs instrumentation_library_logs = 4 [deprecated = true]; + repeated InstrumentationLibraryLogs instrumentation_library_logs = 1000 [deprecated = true]; // This schema_url applies to the data in the "resource" field. It does not apply // to the data in the "scope_logs" field which have their own schema_url field. @@ -105,6 +105,8 @@ message ScopeLogs { // Protobuf format. // This message is deprecated and will be removed on June 15, 2022. message InstrumentationLibraryLogs { + option deprecated = true; + // The instrumentation library information for the logs in this message. // Semantically when InstrumentationLibrary isn't set, it is equivalent with // an empty instrumentation library name (unknown). diff --git a/opentelemetry/proto/metrics/v1/metrics.proto b/opentelemetry/proto/metrics/v1/metrics.proto index d9662447f..46c155fe2 100644 --- a/opentelemetry/proto/metrics/v1/metrics.proto +++ b/opentelemetry/proto/metrics/v1/metrics.proto @@ -79,7 +79,7 @@ message ResourceMetrics { // scope_metrics is not set then the value in instrumentation_library_metrics // SHOULD be used instead by converting InstrumentationLibraryMetrics into ScopeMetrics. // If scope_metrics is set then instrumentation_library_metrics field SHOULD be ignored. - repeated InstrumentationLibraryMetrics instrumentation_library_metrics = 4 [deprecated = true]; + repeated InstrumentationLibraryMetrics instrumentation_library_metrics = 1000 [deprecated = true]; // This schema_url applies to the data in the "resource" field. It does not apply // to the data in the "scope_metrics" field which have their own schema_url field. @@ -105,6 +105,8 @@ message ScopeMetrics { // Protobuf format. // This message is deprecated and will be removed on June 15, 2022. message InstrumentationLibraryMetrics { + option deprecated = true; + // The instrumentation library information for the metrics in this message. // Semantically when InstrumentationLibrary isn't set, it is equivalent with // an empty instrumentation library name (unknown). diff --git a/opentelemetry/proto/trace/v1/trace.proto b/opentelemetry/proto/trace/v1/trace.proto index 56d1305fa..f2c13712b 100644 --- a/opentelemetry/proto/trace/v1/trace.proto +++ b/opentelemetry/proto/trace/v1/trace.proto @@ -79,7 +79,7 @@ message ResourceSpans { // scope_spans is not set then the value in instrumentation_library_spans // SHOULD be used instead by converting InstrumentationLibrarySpans into ScopeSpans. // If scope_spans is set then instrumentation_library_spans field SHOULD be ignored. - repeated InstrumentationLibrarySpans instrumentation_library_spans = 4 [deprecated = true]; + repeated InstrumentationLibrarySpans instrumentation_library_spans = 1000 [deprecated = true]; // This schema_url applies to the data in the "resource" field. It does not apply // to the data in the "scope_spans" field which have their own schema_url field. @@ -105,6 +105,8 @@ message ScopeSpans { // Protobuf format. // This message is deprecated and will be removed on June 15, 2022. message InstrumentationLibrarySpans { + option deprecated = true; + // The instrumentation library information for the spans in this message. // Semantically when InstrumentationLibrary isn't set, it is equivalent with // an empty instrumentation library name (unknown).