Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configuration hot reloading from the target allocator #2032

Closed
swiatekm opened this issue Aug 17, 2023 · 0 comments · Fixed by #2425
Closed

Remove configuration hot reloading from the target allocator #2032

swiatekm opened this issue Aug 17, 2023 · 0 comments · Fixed by #2425
Assignees
Milestone

Comments

@swiatekm
Copy link
Contributor

Target Allocator currently reloads configuration from the config file when it changes. This is an anti-pattern in Kubernetes - Pods should be immutable, and configuration changes should be explicitly rolled out by recreating Pods. We already restart the Target Allocator Deployment when its configuration changes since #1882. As such, the hot reload just makes the semantics more confusing without much benefit.

The plan for removing this would be:

  • Add a feature flag to the target allocator to enable this, disabled by default (breaking change)
  • Two versions later, remove the feature flag and the rest of the hot reload code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant