Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the default scrape interval configurable for Target Allocator #1925

Closed
swiatekm opened this issue Jul 14, 2023 · 0 comments · Fixed by #1923
Closed

Make the default scrape interval configurable for Target Allocator #1925

swiatekm opened this issue Jul 14, 2023 · 0 comments · Fixed by #1923
Labels
area:target-allocator Issues for target-allocator

Comments

@swiatekm
Copy link
Contributor

This is currently hardcoded here:

opentelemetry-operator/cmd/otel-allocator/watcher/promOperator.go

Line 58 in ec1e0a3

// TODO: We should make these durations configurable
.

More broadly, we should probably decide which configuration options from the Prometheus CR we want to support, and make sure they're consistent with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:target-allocator Issues for target-allocator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[target allocator] Make scrape interval configurable swiatekm/opentelemetry-operator
2 participants
@jaronoff97 @swiatekm