Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a managementState field to the Collector CRD to disable the reconciliation #1881

Closed
iblancasa opened this issue Jun 29, 2023 · 1 comment · Fixed by #1888
Closed

Add a managementState field to the Collector CRD to disable the reconciliation #1881

iblancasa opened this issue Jun 29, 2023 · 1 comment · Fixed by #1888
Labels
area:collector Issues for deploying collector enhancement New feature or request

Comments

@iblancasa
Copy link
Contributor

The idea of this task is to add a new field in the CRD called managementState. It would be placed under .spec.managementState for the OpenTelemetry Collector instances.

Possible values:

  • Managed (default value): the reconciliation works currently does
  • Unmanaged: disables the reconciliation

Disabling the reconciliation can be useful in different use cases:

  • Debugging
  • Edit the objects created by the operator without losing the changes (because of the reconciliation)
  • Keep instances without upgrading (if, for whatever reason we need to upgrade the operator and all the instances except some of them)

This feature is something we implemented for the Tempo Operator and it is also implemented in the Loki Operator.

@pavolloffay pavolloffay added the enhancement New feature or request label Jun 30, 2023
@pavolloffay pavolloffay changed the title Add a managementState field to the CRD to disable the reconciliation Add a managementState field to the Collector CRD to disable the reconciliation Jun 30, 2023
@pavolloffay pavolloffay added the area:collector Issues for deploying collector label Jun 30, 2023
@avadhut123pisal
Copy link
Contributor

I can work on this, if it is not already in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:collector Issues for deploying collector enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants