Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add instrumentation of Redis & RabbitMQ #1342

Closed
sr185436 opened this issue Dec 27, 2022 · 10 comments
Closed

How to add instrumentation of Redis & RabbitMQ #1342

sr185436 opened this issue Dec 27, 2022 · 10 comments
Labels

Comments

@sr185436
Copy link

sr185436 commented Dec 27, 2022

How to add instrumentation of Redis & RabbitMQ by using opentelemetry-operator?
Operator v0.66.0 or v0.61.0
.NET version 6

Redis - StackExchange.Redis
RabbitMQ - RabbitMQ.Client 4.0.30319

@Kielek
Copy link
Contributor

Kielek commented Dec 27, 2022

I suppose that the question is related to .NET (based on #1343).

What do you mean by adding Redis and RabbitMQ instrumentations?
Redis should be enabled by default in the latest version operator.

It will be great if you can share

  • operator version
  • .NET version of instrumented applications
  • logs from the OpenTelemetry .NET Automatic Istrumentation. Typically stored by operator under /var/log/opentelemetry/dotnet

from the solution where you expect Redis/RabbitMQ instrumentation and there is no spans for it.

@sr185436
Copy link
Author

No it's not related please help how to add Redis & RabbitMQ instrumentation to the opentelemetry-operator?

@sr185436
Copy link
Author

sr185436 commented Dec 29, 2022

Operator v0.66.0 or v0.61.0
.NET version 6

Appreciate your help.

@pellared
Copy link
Member

What client libraries (together with versions) are you using for Redis & RabbitMQ?

Maybe they are not supported? Check https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/v0.5.0/docs/config.md#traces-instrumentations

@sr185436
Copy link
Author

sr185436 commented Dec 29, 2022

Redis - StackExchange.Redis
RabbitMQ - RabbitMQ.Client 5.2.0 (Version)

@pellared
Copy link
Member

StackExchange.Redis should be instrumented for ≥2.0.405. The lack of instrumentation might be a bug. Please consisder checking https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation and reporting a bug with repro steps in that reprository.

RabbitMQ.Client is not supported.

@Kielek
Copy link
Contributor

Kielek commented Dec 29, 2022

Ref link for RabbitMQ rabbitmq/rabbitmq-dotnet-client#776

@sr185436
Copy link
Author

sr185436 commented Dec 29, 2022

I try to avoid to write code, all idea is to config the operator to trace automatically all, same behavior like sqlClient...
Please help and send me some doc/guide that related to the operator.

@Kielek
Copy link
Contributor

Kielek commented Dec 29, 2022

Operator is using OpenTelemetry .NET Automatic Instrumentation under the hood. I suppose that is it not related to operator if any instrumentation is working for you.

For now, we are not able to propose you any solution for RabbitMQ. It has to be implemented on the RabbitMQ side or we will have to add bytecode instrumentation for this library in Automatic Instrumentation project.
We are open for the contribution in Automatic Instrumentation project. I suppose that RabbitMQ community will be also happy to accept changes.

StackExchange.Redis ≥ 2.0.405 instrumentation is enabled by default. Once again, if it is not working for you we need reproduction steps. Separate repository/zip file following https://stackoverflow.com/help/minimal-reproducible-example will be really helpful. Without this it will be hard/impossible to help you.

@pavolloffay
Copy link
Member

I am closing this request is not related to the operator codebase. Please open a ticket against https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation to support additional instrumentations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants