From 544b228b23d60c1f0d5288011b40171e35471533 Mon Sep 17 00:00:00 2001 From: "marc.pichler" Date: Fri, 9 Sep 2022 11:28:14 +0200 Subject: [PATCH 1/2] chore(sdk-metrics): remove accidental export of the SDK Meter class --- experimental/packages/opentelemetry-sdk-metrics/src/index.ts | 4 ---- .../opentelemetry-sdk-metrics/test/MeterProvider.test.ts | 3 ++- .../test/state/MeterSharedState.test.ts | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/experimental/packages/opentelemetry-sdk-metrics/src/index.ts b/experimental/packages/opentelemetry-sdk-metrics/src/index.ts index e5e1ab6ed2a..30ce7a09d90 100644 --- a/experimental/packages/opentelemetry-sdk-metrics/src/index.ts +++ b/experimental/packages/opentelemetry-sdk-metrics/src/index.ts @@ -67,10 +67,6 @@ export { InstrumentType, } from './InstrumentDescriptor'; -export { - Meter, -} from './Meter'; - export { MeterProvider, MeterProviderOptions, diff --git a/experimental/packages/opentelemetry-sdk-metrics/test/MeterProvider.test.ts b/experimental/packages/opentelemetry-sdk-metrics/test/MeterProvider.test.ts index e8c42bf798b..a7e6ac12fb8 100644 --- a/experimental/packages/opentelemetry-sdk-metrics/test/MeterProvider.test.ts +++ b/experimental/packages/opentelemetry-sdk-metrics/test/MeterProvider.test.ts @@ -15,7 +15,7 @@ */ import * as assert from 'assert'; -import { Meter, MeterProvider, InstrumentType, DataPointType } from '../src'; +import { MeterProvider, InstrumentType, DataPointType } from '../src'; import { assertScopeMetrics, assertMetricData, @@ -25,6 +25,7 @@ import { import { TestMetricReader } from './export/TestMetricReader'; import * as sinon from 'sinon'; import { View } from '../src/view/View'; +import { Meter } from '../src/Meter'; describe('MeterProvider', () => { afterEach(() => { diff --git a/experimental/packages/opentelemetry-sdk-metrics/test/state/MeterSharedState.test.ts b/experimental/packages/opentelemetry-sdk-metrics/test/state/MeterSharedState.test.ts index dc7651f83aa..21f2dce7fd5 100644 --- a/experimental/packages/opentelemetry-sdk-metrics/test/state/MeterSharedState.test.ts +++ b/experimental/packages/opentelemetry-sdk-metrics/test/state/MeterSharedState.test.ts @@ -17,7 +17,6 @@ import * as assert from 'assert'; import * as sinon from 'sinon'; import { - Meter, MeterProvider, DataPointType, View, @@ -29,6 +28,7 @@ import { assertMetricData, defaultInstrumentationScope, defaultResource, sleep } import { TestDeltaMetricReader, TestMetricReader } from '../export/TestMetricReader'; import { MeterSharedState } from '../../src/state/MeterSharedState'; import { CollectionResult } from '../../src/export/MetricData'; +import { Meter } from '../../src/Meter'; describe('MeterSharedState', () => { afterEach(() => { From 5f3348b060101c7def881bde423f6054c1e8e4ae Mon Sep 17 00:00:00 2001 From: "marc.pichler" Date: Fri, 9 Sep 2022 11:34:02 +0200 Subject: [PATCH 2/2] fix(changelog): add changelog entry --- experimental/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 9c3307b0b49..9f65421cd20 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -38,6 +38,7 @@ All notable changes to experimental packages in this project will be documented * `NoopObservableMetric` * `NoopObservableUpDownCounterMetric` * `NoopUpDownCounterMetric` +* chore(sdk-metrics): remove accidental export of the SDK `Meter` class [#3243](https://github.com/open-telemetry/opentelemetry-js/pull/3243) @pichlermarc ### :rocket: (Enhancement)