From 8dc53e24c28417c9129414913be649fa4bf2131a Mon Sep 17 00:00:00 2001 From: legendecas Date: Wed, 29 Sep 2021 11:35:43 +0800 Subject: [PATCH 1/3] test: add esModuleInterop compatibility test --- backwards-compatability/node10/package.json | 2 +- backwards-compatability/node12/package.json | 2 +- backwards-compatability/node8/package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/backwards-compatability/node10/package.json b/backwards-compatability/node10/package.json index 44969816b7a..140fedf95f9 100644 --- a/backwards-compatability/node10/package.json +++ b/backwards-compatability/node10/package.json @@ -5,7 +5,7 @@ "description": "Backwards compatability app for node8 types and the OpenTelemetry Node.js SDK", "main": "index.js", "scripts": { - "test:backcompat": "tsc --noEmit index.ts" + "test:backcompat": "tsc --noEmit index.ts && tsc --noEmit --esModuleInterop index.ts" }, "dependencies": { "@opentelemetry/sdk-node": "0.25.0", diff --git a/backwards-compatability/node12/package.json b/backwards-compatability/node12/package.json index afbf0d8b4a2..714edd0b402 100644 --- a/backwards-compatability/node12/package.json +++ b/backwards-compatability/node12/package.json @@ -5,7 +5,7 @@ "description": "Backwards compatability app for node8 types and the OpenTelemetry Node.js SDK", "main": "index.js", "scripts": { - "test:backcompat": "tsc --noEmit index.ts" + "test:backcompat": "tsc --noEmit index.ts && tsc --noEmit --esModuleInterop index.ts" }, "dependencies": { "@opentelemetry/sdk-node": "0.25.0", diff --git a/backwards-compatability/node8/package.json b/backwards-compatability/node8/package.json index 37a66f6652a..9e4512f884f 100644 --- a/backwards-compatability/node8/package.json +++ b/backwards-compatability/node8/package.json @@ -5,7 +5,7 @@ "description": "Backwards compatability app for node8 types and the OpenTelemetry Node.js SDK", "main": "index.js", "scripts": { - "test:backcompat": "tsc --noEmit index.ts" + "test:backcompat": "tsc --noEmit index.ts && tsc --noEmit --esModuleInterop index.ts" }, "dependencies": { "@opentelemetry/sdk-node": "0.25.0", From 1a395c4777ccaf821d20ad263a7fcad2f8645171 Mon Sep 17 00:00:00 2001 From: legendecas Date: Thu, 30 Sep 2021 01:45:36 +0800 Subject: [PATCH 2/3] fixup! invalidate CI caches --- experimental/backwards-compatability/node8/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/experimental/backwards-compatability/node8/package.json b/experimental/backwards-compatability/node8/package.json index 9e4512f884f..8d93a481693 100644 --- a/experimental/backwards-compatability/node8/package.json +++ b/experimental/backwards-compatability/node8/package.json @@ -16,5 +16,6 @@ "typescript": "4.3.5" }, "author": "OpenTelemetry Authors", + "touch-the-file": "to-invalidate-caches", "license": "Apache-2.0" } From dbca15b56e758b551061f4b57216abfd165b774c Mon Sep 17 00:00:00 2001 From: legendecas Date: Thu, 30 Sep 2021 16:48:34 +0800 Subject: [PATCH 3/3] Revert "fixup! invalidate CI caches" This reverts commit 1a395c4777ccaf821d20ad263a7fcad2f8645171. --- experimental/backwards-compatability/node8/package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/experimental/backwards-compatability/node8/package.json b/experimental/backwards-compatability/node8/package.json index 8d93a481693..9e4512f884f 100644 --- a/experimental/backwards-compatability/node8/package.json +++ b/experimental/backwards-compatability/node8/package.json @@ -16,6 +16,5 @@ "typescript": "4.3.5" }, "author": "OpenTelemetry Authors", - "touch-the-file": "to-invalidate-caches", "license": "Apache-2.0" }