Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export MultiSpanProcessor #4189

Closed
anuraaga opened this issue Oct 5, 2023 · 4 comments
Closed

Export MultiSpanProcessor #4189

anuraaga opened this issue Oct 5, 2023 · 4 comments

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Oct 5, 2023

NB: Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue on opentelemetry-specification first.

Is your feature request related to a problem? Please describe.

NodeSdk accepts a single span processor, and because MultiSpanProcessor is not exported but is just an implementation detail of addSpanProcessor, there doesn't seem to be a way to use NodeSdk with multiple span processors.

Describe the solution you'd like

Export MultiSpanProcessor for use.

Describe alternatives you've considered

Can add an array field accepting multiple span processors in NodeSdk. It seems complicated given the fields there already are (there is already tension between the incompatible traceExporter and spanProcessor fields.

Additional context

Add any other context or screenshots about the feature request here.

Copy link

github-actions bot commented Dec 4, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 4, 2023
@lmnogues
Copy link

lmnogues commented Dec 4, 2023

as an alternative i've duplicated the muiltispanprocessor inside my own app but it feels wrong to do

@github-actions github-actions bot removed the stale label Dec 11, 2023
@YunosukeY
Copy link

Is PR #4454 a solution to this request?

@anuraaga
Copy link
Contributor Author

Yeah it looks like it, unfortunate now there's three incompatible fields, traceExporter spanProcessor spanProcessors. But it's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants