Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should PeriodicExportingMetricReader call forceFlush on shutdown? #3659

Closed
1 of 2 tasks
danielgblanco opened this issue Mar 7, 2023 · 2 comments
Closed
1 of 2 tasks
Labels

Comments

@danielgblanco
Copy link
Contributor

danielgblanco commented Mar 7, 2023

More context on open-telemetry/opentelemetry-specification#2983

Although the OpenTelemetry Specification does not state it (see issue above), other language SDKs (e.g. Python or Java) perform the effects of a forceFlush as part of the call to shutdown. In opentelemetry-js, the MeterProvider.shutdown() has a comment indicating that a call to shutdown will flush all buffered data, but the implementation of the PeriodicExportingMetricReader.shutdown() does not.

I'd like to discuss if Node should follow the same implementation, or if maintainers of this repo have any opinions on the opentelemetry-specification issue above. Thanks.

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first
@github-actions
Copy link

github-actions bot commented May 8, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 8, 2023
@github-actions
Copy link

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant