Add host.id detection to HostDetector

[svrnm]

Is your feature request related to a problem? Please describe.

Similar to container.id the attribute host.id can be super helpful to provide correlation between infra & app data in the backend. Many (non-containerised) linux systems have a file called "machine-id" that holds a unique identifier, that is created on first boot and stays stable from there. I checked CentOS, Debian & Alpine and all of them provide that file in /etc/machine-id. Historically this file could also live at /var/lib/dbus/machine-id. I would like to have the HostDetector extended to check for these files and add host.id if available.

Describe the solution you'd like

I have the code ready at https://github.com/svrnm/opentelemetry-js/tree/add-host-id-detection, so if this is something worth being added I can raise the PR:

• https://github.com/svrnm/opentelemetry-js/blob/add-host-id-detection/packages/opentelemetry-resources/src/platform/node/HostDetector.ts
• https://github.com/svrnm/opentelemetry-js/blob/add-host-id-detection/packages/opentelemetry-resources/test/detectors/node/HostDetector.test.ts

Additional context

Spec Issue: open-telemetry/opentelemetry-specification#2978

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[svrnm]

@open-telemetry/javascript-approvers any thoughts on this? happy to raise the PR

[legendecas]

PR: #3575

[svrnm]

PR: #3575

Makes me code obsolete 😢 ... na, I'm fine with that, @mwear's code is much better than mine, will give it a look :-)

[mwear]

Sorry @svrnm, I didn't realize you were also working this. My bad. I appreciate the reviews! Let me know if I can make it up somehow.

[svrnm]

Sorry @svrnm, I didn't realize you were also working this. My bad. I appreciate the reviews! Let me know if I can make it up somehow.

No worries, your code is much better:-) If your eally insist on making it up, take a few minutes to update the docs after your PR gets merged:

https://opentelemetry.io/docs/instrumentation/js/resources/

:-)