Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreNetworkEvents flag to @opentelemetry/instrumentation-xml-http-request to suppress extra span events #3266

Closed
chris-armstrong opened this issue Sep 19, 2022 · 3 comments

Comments

@chris-armstrong
Copy link

Is your feature request related to a problem? Please describe.

@opentelemetry/instrumentation-xml-http-request adds a number of span events for each HTTP request used to profile different stages of the request. It would be handy to turn this off, as it is not useful for our use case and consumes unwanted resources.

The @opentelemetry/instrumentation-fetch implementation has a similar feature with the ignoreNetworkEvents flag.

Describe the solution you'd like

A new configuration option ignoreNetworkEvents that suppresses the generation of span events related to the network timing e.g.

new XMLHttpRequestInstrumentation({
  enabled: true,
  ignoreNetworkEvents: true,
});

Describe alternatives you've considered

A customisation hook for the network events may be another option, but I don't know any use cases for that.

Additional context

N/A

@legendecas
Copy link
Member

I believe this can be a good-to-have feature that can be generalized for web instrumentation (like mentioned in #3062 (comment)).

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Nov 21, 2022
@github-actions
Copy link

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants