From 26dfc70841548060d1495b2063eb6a25c41cb7f9 Mon Sep 17 00:00:00 2001
From: Marc Pichler <marc.pichler@dynatrace.com>
Date: Thu, 13 Apr 2023 11:31:29 +0200
Subject: [PATCH] fix(sdk-node)!: remove unused defaultAttributes option
 (#3724)

---
 README.md                                                 | 5 +++++
 experimental/CHANGELOG.md                                 | 3 +++
 experimental/packages/opentelemetry-sdk-node/src/types.ts | 3 +--
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 1b68f88e970..9daf9d73858 100644
--- a/README.md
+++ b/README.md
@@ -279,6 +279,11 @@ These instrumentations are hosted at <https://github.com/open-telemetry/opentele
 
 ## Upgrade guidelines
 
+### 0.37.x to 0.38.0
+
+- `@opentelemetry/sdk-node` `NodeSDKConfiguration.defaultAttributes` has been unused and was removed as the concept does not exist in OpenTelemetry anymore
+  - Please use `NodeSDKConfiguration.resource` instead.
+
 ### 0.35.x to 0.36.0
 
 - `@opentelemetry/sdk-node` changed `await start()` to now be synchronous
diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md
index 928a5499cc3..fff3c20aa6d 100644
--- a/experimental/CHANGELOG.md
+++ b/experimental/CHANGELOG.md
@@ -6,6 +6,9 @@ All notable changes to experimental packages in this project will be documented
 
 ### :boom: Breaking Change
 
+* fix(sdk-node)!: remove unused defaultAttributes option [#3724](https://github.com/open-telemetry/opentelemetry-js/pull/3724) @pichlermarc
+  * Please use `NodeSDKConfiguration.resource` instead
+
 ### :rocket: (Enhancement)
 
 ### :bug: (Bug Fix)
diff --git a/experimental/packages/opentelemetry-sdk-node/src/types.ts b/experimental/packages/opentelemetry-sdk-node/src/types.ts
index 38178e58c56..82074719dff 100644
--- a/experimental/packages/opentelemetry-sdk-node/src/types.ts
+++ b/experimental/packages/opentelemetry-sdk-node/src/types.ts
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import type { ContextManager, SpanAttributes } from '@opentelemetry/api';
+import type { ContextManager } from '@opentelemetry/api';
 import { TextMapPropagator } from '@opentelemetry/api';
 import { InstrumentationOption } from '@opentelemetry/instrumentation';
 import { Detector, DetectorSync, Resource } from '@opentelemetry/resources';
@@ -30,7 +30,6 @@ import {
 export interface NodeSDKConfiguration {
   autoDetectResources: boolean;
   contextManager: ContextManager;
-  defaultAttributes: SpanAttributes;
   textMapPropagator: TextMapPropagator;
   metricReader: MetricReader;
   views: View[];