From 253126394872b9f33bfb961e02b87a4fe0d5292b Mon Sep 17 00:00:00 2001 From: Amir Blum Date: Mon, 15 May 2023 21:38:44 +0300 Subject: [PATCH] fix(sdk-node): use resource interface instead of concrete class (#3803) --- experimental/CHANGELOG.md | 2 ++ experimental/packages/opentelemetry-sdk-node/src/types.ts | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index f9adec9c9a0..3ee06e9fc81 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -16,6 +16,8 @@ All notable changes to experimental packages in this project will be documented ### :bug: (Bug Fix) +* fix(sdk-node): use resource interface instead of concrete class [#3803](https://github.com/open-telemetry/opentelemetry-js/pull/3803) @blumamir + ### :books: (Refine Doc) ### :house: (Internal) diff --git a/experimental/packages/opentelemetry-sdk-node/src/types.ts b/experimental/packages/opentelemetry-sdk-node/src/types.ts index 82074719dff..03efc311420 100644 --- a/experimental/packages/opentelemetry-sdk-node/src/types.ts +++ b/experimental/packages/opentelemetry-sdk-node/src/types.ts @@ -17,7 +17,7 @@ import type { ContextManager } from '@opentelemetry/api'; import { TextMapPropagator } from '@opentelemetry/api'; import { InstrumentationOption } from '@opentelemetry/instrumentation'; -import { Detector, DetectorSync, Resource } from '@opentelemetry/resources'; +import { Detector, DetectorSync, IResource } from '@opentelemetry/resources'; import { MetricReader, View } from '@opentelemetry/sdk-metrics'; import { Sampler, @@ -34,7 +34,7 @@ export interface NodeSDKConfiguration { metricReader: MetricReader; views: View[]; instrumentations: InstrumentationOption[]; - resource: Resource; + resource: IResource; resourceDetectors: Array; sampler: Sampler; serviceName?: string;