-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: automation to cut release automatically when core one is done to keep versions in sync #457
Comments
well it will de sync sooner or later, once we release 1.0 it might be in sync for a while, but later there is a chance it will desync anyway. I would not be worry about it, these are 2 repos anyway. |
If we don't sync them, we at least need a way to make it immediately obvious which versions are compatible without having to check some readme. 1 possible solution is to peer depend on API. If we peer depend on the compatible API version, it will complain at install time if the API version the user installed is incompatible. Since the instrumentations only use the API and don't interact directly with SDK, this should be fine. This is basically the same reason we decided to do this for core, and i've seen other "in the wild" plugins and instrumentations do it this way too. |
+1 that peerDependencies are the right way to warn on this. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
I'll go ahead and close this, we implemented a while ago peerDependency on the api |
Based on #448. We need to answer different questions before implementing this:
The text was updated successfully, but these errors were encountered: