Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry/auto-instrumentations-web 0.34.0] Update zone.js peer dependency #1820

Closed
ebussieres opened this issue Nov 23, 2023 · 4 comments · Fixed by #1934
Closed

[opentelemetry/auto-instrumentations-web 0.34.0] Update zone.js peer dependency #1820

ebussieres opened this issue Nov 23, 2023 · 4 comments · Fixed by #1934
Labels
enhancement New feature or request pkg:auto-instrumentations-web pkg:instrumentation-user-interaction up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@ebussieres
Copy link

I'm wondering why zone.js peer dependency is hardcoded to version 0.11.4. Why caret was not used ? Change was introduced in #1768.

I have an angular 17 app and i'm using zone.js 0.14.x version. This is preventing a lot of app to use the latest @opentelemetry/auto-instrumentations-web version.

@pichlermarc
Copy link
Member

Hi, thanks for reaching out.

It's a pinned peer dependency in one of the instrumentations included in the meta-package; Implicitly this was true for a while now as it is pinned in that instrumentation as well. I think unpinning it in both the metapackage (@opentelemetry/auto-instrumentations-web) and (@opentelemetry/instrumentation-user-interaction) would be the way forward to enable people to use later versions.

Testing would be vital if the range is expanded to also include 0.14 (using a caret will only pull in 0.14.x, not <1 as minor bumps in pre-release versions indicate breaking changes according to semver), so I'd recommend whoever picks this up also adds a test-all-versions script for 0.11, 0.12, 0.13 and 0.14.

Note: I think this would also require changes in the core repo as the package also depends on @opentelemetry/context-zone-peer-dep, that change needs to be made there first otherwise all changes here will not actually allow for anything later than 0.11.

I'll mark this as triage since I'm not sure if I'm missing something, I'll bring this up with a group of contributors during bug triage tomorrow - as there can be breaking changes in later minor versions of zone.js this could also be categorized as a feature request.

@dyladan dyladan added enhancement New feature or request and removed bug Something isn't working triage labels Nov 29, 2023
@dyladan dyladan changed the title [opentelemetry/auto-instrumentations-web 0.34.0] zone.js peer dependency [opentelemetry/auto-instrumentations-web 0.34.0] Update zone.js peer dependency Nov 29, 2023
@dyladan
Copy link
Member

dyladan commented Nov 29, 2023

Added the enhancement label and modified the PR title. This seems to be a request to support other versions of zone.js. There is a similar issue for the zone context manager in the core repo.

@dyladan dyladan added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 29, 2023
@starushykart
Copy link

Hi, guys!
Many thanks for your work!
Is there an understanding of when the issue will be resolved?

@pichlermarc
Copy link
Member

@starushykart no ETA at the moment as no one is actively working on it. PRs from volunteers are welcome 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment