Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change introduced in SpanData, ReadableSpan interfaces #4639

Closed
jkwatson opened this issue Jul 27, 2022 · 2 comments · Fixed by #4640
Closed

Breaking change introduced in SpanData, ReadableSpan interfaces #4639

jkwatson opened this issue Jul 27, 2022 · 2 comments · Fixed by #4640
Labels
Bug Something isn't working

Comments

@jkwatson
Copy link
Contributor

This PR: #4256 Introduced new methods to public interfaces without providing default implementations. This is a breaking change, and hence a bug. We need to add default implementations ASAP and issue a patch release to correct this.

@jkwatson jkwatson added the Bug Something isn't working label Jul 27, 2022
@jack-berg
Copy link
Member

jack-berg commented Jul 27, 2022

I see additional methods without default implementation added to ReadableSpan and SpanData.

There's also an abstract method added to the autovalue builder TestSpanData.Builder#setInstrumentationScopeInfo, but I believe we don't have to add a default implementation because the builder already has package private methods that prevents users from implementing their own.

That was first published in 1.13.0. Thoughts on patching back to 1.13.0, or just the latest 1.16.0?

@jkwatson
Copy link
Contributor Author

The user who reported this says they were able to workaround, so perhaps we can put off releasing a patch until we have a user who needs it. We should still add the default methods, I think, so it isn't a problem moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants