Verify actual status instead of just errored

[anuraaga]

OTel spans have a status with different codes but many of our tests only test success vs error. We should migrate to asserting on the status instead.

[trask]

Before anyone picks up this issue, it sounds span status may be going away open-telemetry/oteps#123 (comment)

[breedx-splk]

There was a LOT of discussion around the removal of Span.Status but according to this comment it looks like there was a decision to remove it, but then according to the actual span spec today (which is frozen), spans definitely still have a status.

Since this issue has been around for a while, maybe we can tweak it to help foster contribution. How about splitting this into smaller, more targeted issues? There are a LOT of tests, and a LOT of usages of SpanAssert.errored().

Suggest picking our top/favorite instrumentations that could benefit from status checking and put those in a new issue or calling them out by name here with more detail (eg. what status is expected and if semantic conventions are also to be verified).