You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When a VirtualField is added to a Serializable class that doesn't have a pre-computed serialVersionUID the added fields & interfaces will alter the default serialVersionUID computation.
Describe the solution you'd like
When a virtual field is being installed we could compute the UID ourselves - ASM even has a helper class for that: SerialVersionUIDAdder.
This behavior should be configurable (enabled by default); it is possible (though very unlikely) that this behavior might break the instrumented application - apparently it is possible to configure Java crypto so that it's not able to compute SHA hashes due to that.
Is your feature request related to a problem? Please describe.
When a
VirtualField
is added to aSerializable
class that doesn't have a pre-computedserialVersionUID
the added fields & interfaces will alter the defaultserialVersionUID
computation.Describe the solution you'd like
When a virtual field is being installed we could compute the UID ourselves - ASM even has a helper class for that:
SerialVersionUIDAdder
.This behavior should be configurable (enabled by default); it is possible (though very unlikely) that this behavior might break the instrumented application - apparently it is possible to configure Java crypto so that it's not able to compute SHA hashes due to that.
Additional context
DataDog also does that in their agent: https://github.com/DataDog/dd-trace-java/blob/master/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/context/FieldBackedContextInjector.java#L487
The text was updated successfully, but these errors were encountered: