Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken JMS MessageProducer propagation #2420

Closed
mateuszrzeszutek opened this issue Feb 26, 2021 · 0 comments · Fixed by #2702
Closed

Broken JMS MessageProducer propagation #2420

mateuszrzeszutek opened this issue Feb 26, 2021 · 0 comments · Fixed by #2702
Labels
bug Something isn't working

Comments

@mateuszrzeszutek
Copy link
Member

Describe the bug
JmsMessageProducerInstrumentation instruments two methods with two different advice classes: one of them injects the context into the message, the other does not.

Additional context
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/jms-1.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jms/JmsMessageProducerInstrumentation.java#L80
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/jms-1.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jms/JmsMessageProducerInstrumentation.java#L117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JMS context propagation problems mateuszrzeszutek/opentelemetry-java-instrumentation
1 participant
@mateuszrzeszutek