Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests and smoke tests against IBM JVM #1633

Closed
trask opened this issue Nov 14, 2020 · 4 comments
Closed

Run tests and smoke tests against IBM JVM #1633

trask opened this issue Nov 14, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Nov 14, 2020

We used to run tests against IBM JVM before #129, would be good to bring this back so we can say we support Java 8+ without adding the qualification that we only support (test against) OpenJDK-based JVMs.

@trask trask added the enhancement New feature or request label Nov 14, 2020
@anuraaga
Copy link
Contributor

It seems like both of our techniques for downloading Java, GHA setup-java and Gradle have vendor-specific Java downloading targeted to their next release

actions/setup-java#98
gradle/gradle#14802

While manually downloading is always an option, the simplest is probably to start with only the smoke tests and wait for one of these.

@iNikem
Copy link
Contributor

iNikem commented Dec 16, 2020

It is very easy now to add to our smoke tests, e.g. for jetty. And we will add that for WebSphere Liberty when that support lands here "soon". Do we want both jdk8 and 11 from IBM or one is enough? Any opinions?

@trask
Copy link
Member Author

trask commented Dec 16, 2020

Both 👍

@mateuszrzeszutek
Copy link
Member

Implemented in smoke tests a while ago in #2386; there's a separate issue #3244 about instrumentation tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants