Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check async redis instrumentation #1139

Closed
anuraaga opened this issue Sep 1, 2020 · 1 comment
Closed

Check async redis instrumentation #1139

anuraaga opened this issue Sep 1, 2020 · 1 comment

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Sep 1, 2020

I just noticed that for example, LettuceAsyncClientTest doesn't actually verify multiple spans end up in the same trace.

https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/master/instrumentation/lettuce/lettuce-5.0/src/test/groovy/LettuceAsyncClientTest.groovy

This might be because we don't have a root span in the test, or because the instrumentation of the future return types doesn't work correctly. We should have test cases for this too.

@trask
Copy link
Member

trask commented Aug 25, 2021

Closed by #3839

@trask trask closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants