From faca68a625ac9537dde710a05e50343c9cdcdc7d Mon Sep 17 00:00:00 2001 From: Robert Pajak Date: Thu, 16 Jan 2025 14:22:35 +0100 Subject: [PATCH 1/3] log: Remove the notices fom Logger to make the whole Logs API user-facing --- log/logger.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/log/logger.go b/log/logger.go index 0773a49b608..d7d8831be5b 100644 --- a/log/logger.go +++ b/log/logger.go @@ -28,9 +28,6 @@ type Logger interface { // // Implementations of this method need to be safe for a user to call // concurrently. - // - // Notice: Emit is intended to be used by log bridges. - // Is should not be used for writing instrumentation. Emit(ctx context.Context, record Record) // Enabled returns whether the Logger emits for the given context and @@ -53,9 +50,6 @@ type Logger interface { // // Implementations of this method need to be safe for a user to call // concurrently. - // - // Notice: Enabled is intended to be used by log bridges. - // Is should not be used for writing instrumentation. Enabled(ctx context.Context, param EnabledParameters) bool } From f0b05c7879ddfdfacaa7d8e2f98fe98d8cd1a4e3 Mon Sep 17 00:00:00 2001 From: Robert Pajak Date: Thu, 16 Jan 2025 14:26:01 +0100 Subject: [PATCH 2/3] Update changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8123dcec87c..e4019029de2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm ## [Unreleased] +### Changed + +- Remove the notices fom `Logger` to make the whole Logs API user-facing in `go.opentelemetry.io/otel/log`. (#6167) + ### Fixed - Relax minimum Go version to 1.22.0 in various modules. (#6073) From ec285141d1953fe32bc8112c7713cc967d585d02 Mon Sep 17 00:00:00 2001 From: Robert Pajak Date: Thu, 16 Jan 2025 14:27:13 +0100 Subject: [PATCH 3/3] Fix typo --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e4019029de2..b61b8bd3a09 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm ### Changed -- Remove the notices fom `Logger` to make the whole Logs API user-facing in `go.opentelemetry.io/otel/log`. (#6167) +- Remove the notices from `Logger` to make the whole Logs API user-facing in `go.opentelemetry.io/otel/log`. (#6167) ### Fixed