Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlpmetrichttp otlptracehttp: Handle non-protobuf responses #4717

Closed
pellared opened this issue Nov 14, 2023 · 0 comments · Fixed by #4719
Closed

otlpmetrichttp otlptracehttp: Handle non-protobuf responses #4717

pellared opened this issue Nov 14, 2023 · 0 comments · Fixed by #4719
Assignees
Labels
bug Something isn't working pkg:exporter:otlp Related to the OTLP exporter package
Milestone

Comments

@pellared
Copy link
Member

pellared commented Nov 14, 2023

From: https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md#binary-protobuf-encoding

The client and the server MUST set "Content-Type: application/x-protobuf" request and response headers when sending binary Protobuf encoded payload.

Currently the exporter expects that the server to always respond with binary Protobuf encoded payload, but it may return something else e.g. text/plain with OK content.

See:

@pellared pellared added the bug Something isn't working label Nov 14, 2023
@pellared pellared changed the title otlpmetrichttp otlptracehttp: Do not otlpmetrichttp otlptracehttp: Handle non-protobuf responses Nov 14, 2023
@pellared pellared added enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package labels Nov 14, 2023
@pellared pellared self-assigned this Nov 14, 2023
@dashpole dashpole removed the enhancement New feature or request label Nov 16, 2023
@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants