Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated otel/metric/global package #3819

Closed
3 tasks
MrAlias opened this issue Feb 28, 2023 · 1 comment · Fixed by #3829
Closed
3 tasks

Remove the deprecated otel/metric/global package #3819

MrAlias opened this issue Feb 28, 2023 · 1 comment · Fixed by #3829
Assignees
@MrAlias
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Milestone
v1.15.0-RC2

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Feb 28, 2023 •
edited
Loading

Blocked by the v1.15.0-RC1 relase.

  • Move all metric global functionality out of go.opentelemetry.io/otel/metric/internal/global and go.opentelemetry.io/otel/metric/global and into go.opentelemetry.io/otel/internal/global and go.opentelemetry.io/otel
  • Remove go.opentelemetry.io/otel/metric/internal/global and go.opentelemetry.io/otel/metric/global
  • Remove the staticcheck lint disablement (add in 6c495fb)
@MrAlias MrAlias added pkg:API Related to an API package area:metrics Part of OpenTelemetry Metrics labels Feb 28, 2023
@MrAlias MrAlias added this to the v1.15.0 milestone Feb 28, 2023
@github-project-automation github-project-automation bot moved this to Triage Needed in Go: Metric API (GA) Feb 28, 2023
@MrAlias MrAlias mentioned this issue Feb 28, 2023
Merged
@MrAlias MrAlias moved this from Triage Needed to Blocked in Go: Metric API (GA) Feb 28, 2023
@MrAlias MrAlias moved this from Blocked to In Progress in Go: Metric API (GA) Mar 2, 2023
@MrAlias MrAlias self-assigned this Mar 2, 2023
@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 2, 2023

  • Move the error handling back from go.opentelemetry.io/otel/internal/global into go.opentelemetry.io/otel (revert f6f5505)

I'm going to remove this from the action items. The metric API has errors the propagator and trace APIs do not. They need to be handled in the same way the currently are so the error handling needs to live in the internal global package still.

@MrAlias MrAlias mentioned this issue Mar 2, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Metric API (GA) Mar 7, 2023
@MrAlias MrAlias modified the milestones: v1.15.0, v1.15.0-RC2 Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Projects
No open projects
Go: Metric API (GA)
Status: Done
Milestone
v1.15.0-RC2
Development

Successfully merging a pull request may close this issue.

Remove the deprecated otel/metric/global pkg MrAlias/opentelemetry-go
1 participant
@MrAlias