-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify compliant metric API specification implementation: Instrument Asynchronous Counter #3375
Comments
With #3454 now complete, our implementation is compliant. |
We do not follow this optional criteria. We instead follow more common Go method naming and use |
I'm going to assume the authors intended "recommended" to be the normative key word "RECOMMENDED". We do not follow this recommendation. #3453 is tracking this issue. |
This looks to be an inappropriate use of the normative key word "MAY" here. For what it's worth, we do choose the option to design an idiomatic approach. The single callback design is being added in #3507, and the multi-callback is being defined in #3564. |
This is all not relevant to the API. |
The API does not handle collection cycles or the timestamping of observations, that is done by implementations receiving data from the API. Our implementation seems to comply with this as it treats observations agnostically regarding the time an observation occurs. |
Similar to discussed here we pass a |
Every normative clause from the |
The text was updated successfully, but these errors were encountered: