-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align view configuration with specification #3241
Comments
The current proposal in #3210 is to move the view registration into the |
This was decided to take this form for two reasons:
We do comply with the wording of the spec, Views are "registered" with a MeterProvider via only an Furthermore, this was the intent of views, as expressed in spec meetings on this subject. |
This sounds good 👍, we just need to ensure the specification is updated to reflect this intention before we can release a stable package. |
It doesn't seem like open-telemetry/opentelemetry-specification#2288 is going to be resolved any time soon. I think we need to move this issue to |
Currently, the specification defines view configuration to be associated with a
MeterProvider
:Furthermore, it implies this registration is a one-to-one mapping between views and
MeterProvider
:Our current implementation registers views in conjunction with a
Reader
. There is a one-to-one mapping of views toReader
. There can be multiple of these pairs registered with aMeterProvider
.This issue is to serve as block to releasing the metric SDK as stable until the specification is updated (see open-telemetry/opentelemetry-specification#2288) or we change how we register views.
The text was updated successfully, but these errors were encountered: