Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Resource attributes from the zipkin exporter #2588

Closed
tttanikawa opened this issue Feb 8, 2022 · 0 comments · Fixed by #2589
Closed

Export Resource attributes from the zipkin exporter #2588

tttanikawa opened this issue Feb 8, 2022 · 0 comments · Fixed by #2589
Labels
enhancement New feature or request
Milestone
untracked

Comments

@tttanikawa
Copy link
Contributor

tttanikawa commented Feb 8, 2022 •
edited
Loading

Problem Statement

Currently, the zipkin exporter only exports the semconv.ServiceName key-value in the Resource attributes.
https://github.com/open-telemetry/opentelemetry-go/blob/main/exporters/zipkin/model.go#L82
Other attributes in the Resource will be ignored (e.g. semconv.ServiceVersion).

Proposed Solution

I think it is better to export all attributes in Resource as Tags field.
https://github.com/open-telemetry/opentelemetry-go/blob/main/exporters/zipkin/model.go#L178
@tttanikawa tttanikawa added the enhancement New feature or request label Feb 8, 2022
@tttanikawa tttanikawa mentioned this issue Feb 8, 2022
Merged
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Export resource attributes from zipkin exporter tttanikawa/opentelemetry-go
2 participants
@pellared @tttanikawa