-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpanID, TraceID, KeyValue and other structs cannot be unmarshalled from JSON #1819
Comments
I'm not sure that this is a feature we want to provide. The Thoughts @open-telemetry/go-approvers? |
From SIG:
|
@pellared is this issue available? |
Description
A number of structs, e.g.
trace.SpanID
, defineMarshalJSON
methods but not the correspondingUnmarshalJSON
. This means that the JSON written by the stdout exporter, which consists of a stream of[]*SpanSnapshot
values, cannot be unmarshalled back into Go objects easily.Environment
Steps To Reproduce
Expected behavior
It would be helpful if the JSON produced by marshalling a slice of
SpanSnapshot
s was easily unmashalled back into a slice ofSpanSnapshots
.The text was updated successfully, but these errors were encountered: