From e209ee7585bcb307539a4d58ff16d39b640f58f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Carlos=20Ch=C3=A1vez?= Date: Mon, 30 Aug 2021 20:29:22 +0200 Subject: [PATCH] chore(exporter/zipkin): improves logging on invalid collector. (#2191) * chore(exporter/zipkin): improves logging on invalid collector. * tests: fixes tests. Co-authored-by: Anthony Mirabella --- exporters/zipkin/zipkin.go | 4 ++-- exporters/zipkin/zipkin_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/exporters/zipkin/zipkin.go b/exporters/zipkin/zipkin.go index d9fb1604fda..8de40472224 100644 --- a/exporters/zipkin/zipkin.go +++ b/exporters/zipkin/zipkin.go @@ -91,10 +91,10 @@ func New(collectorURL string, opts ...Option) (*Exporter, error) { } u, err := url.Parse(collectorURL) if err != nil { - return nil, fmt.Errorf("invalid collector URL: %v", err) + return nil, fmt.Errorf("invalid collector URL %q: %v", collectorURL, err) } if u.Scheme == "" || u.Host == "" { - return nil, errors.New("invalid collector URL") + return nil, fmt.Errorf("invalid collector URL %q: no scheme or host", collectorURL) } cfg := config{} diff --git a/exporters/zipkin/zipkin_test.go b/exporters/zipkin/zipkin_test.go index bac8cdc2950..3e8e9c910ff 100644 --- a/exporters/zipkin/zipkin_test.go +++ b/exporters/zipkin/zipkin_test.go @@ -71,7 +71,7 @@ func TestNewRawExporterShouldFailInvalidCollectorURL(t *testing.T) { ) assert.Error(t, err) - assert.EqualError(t, err, "invalid collector URL") + assert.EqualError(t, err, "invalid collector URL \"localhost\": no scheme or host") assert.Nil(t, exp) }