Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add Jaeger propagator #358

Closed
TommyCpp opened this issue Sep 11, 2020 · 2 comments · Fixed by #375
Closed

Proposal: Add Jaeger propagator #358

TommyCpp opened this issue Sep 11, 2020 · 2 comments · Fixed by #375
Assignees
Labels
area: propagators Related to the propagators module
Milestone

Comments

@TommyCpp
Copy link
Contributor

As detailed in spec, SDK should come with B3 and Jaeger propagators. We already have B3 propagator, so it make sense to add a jaeger propagator.

I'd like to work on that if that sounds good.

@hairyhenderson
Copy link
Contributor

FWIW, I'm in favour of this - we've been working on migrating from OT/Jaeger to OTel internally and trace propagation between services has been a big concern.

Glad to see that open-telemetry/opentelemetry-specification#770 was merged, and I wish that I'd seen that before starting to move some of our services that don't support OTel over to Zipkin (notably, nginx)

@MrAlias
Copy link
Contributor

MrAlias commented Sep 22, 2020

@TommyCpp thanks for identifying this and picking up the task. The help is definitely appreciated.

We have interpreted the specification ...

MUST be distributed as OpenTelemetry extension packages

as saying the B3 and Jaeger propagators should live in the contrib repository. I'm going to migrate this issue there to track this work.

@MrAlias MrAlias transferred this issue from open-telemetry/opentelemetry-go Sep 22, 2020
@MrAlias MrAlias added area: propagators Related to the propagators module priority:p2 labels Sep 22, 2020
@MrAlias MrAlias added this to the RC1 milestone Sep 22, 2020
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: propagators Related to the propagators module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants