Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chloggen prints all output to stdout by default #611

Closed
mowies opened this issue Nov 6, 2024 · 7 comments · Fixed by #612
Closed

chloggen prints all output to stdout by default #611

mowies opened this issue Nov 6, 2024 · 7 comments · Fixed by #612

Comments

@mowies
Copy link
Member

mowies commented Nov 6, 2024

While doing some debugging, I noticed that chloggen outputs to stdout by default.
That has a few issues in the repos that use this tool, e.g. the opentelemetry-collector repos where the output is redirected to file which doesn't work as it should.

Example:

chloggen update --config ./path/to/config --dry 1>stdout.md 2>stderr.md

This will result in stdout.md being empty and stderr.md having the changelog dry run content.

@mowies
Copy link
Member Author

mowies commented Nov 6, 2024

I will provide a small fix for this

@mowies
Copy link
Member Author

mowies commented Nov 6, 2024

@mx-psi is this worth a release? I feel it affects many things and should probably be updated rather sooner than later

@mx-psi
Copy link
Member

mx-psi commented Nov 6, 2024

@mx-psi I would support doing a release for this. Could you create the prep PR following these steps: https://github.com/open-telemetry/opentelemetry-go-build-tools/blob/main/RELEASING.md ? I can approve and deal with the tagging once it is merged

@mowies
Copy link
Member Author

mowies commented Nov 6, 2024

sure, i'll do the prep work :)
should this be 0.14.1 since it's just a bugfix or rather 0.15.0?

@mowies
Copy link
Member Author

mowies commented Nov 6, 2024

i'll assume it's 0.15.0 since there basically never was a patch version bump in recent releases :)

@mx-psi
Copy link
Member

mx-psi commented Nov 6, 2024

0.15.0 works for me

@mowies
Copy link
Member Author

mowies commented Nov 6, 2024

@mx-psi PR is open: #614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants