Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing RC versioning pattern #2991

Closed
glucaci opened this issue Mar 8, 2022 · 7 comments
Closed

Consider changing RC versioning pattern #2991

glucaci opened this issue Mar 8, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request infra Infra work - CI/CD, code coverage, linters
Milestone

Comments

@glucaci
Copy link
Contributor

glucaci commented Mar 8, 2022

With the current versioning pattern in nuget.org is not listed the latest released package.

e.g.
OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs

image

This can be fixed with the following pattern: 1.0.0-rc.10
This is the same pattern already used for beta releases.

Thanks!

@glucaci glucaci added the enhancement New feature or request label Mar 8, 2022
@tomkerkhove
Copy link
Contributor

Bumped into this yesterday myself and agreed it would be nicer. VS also didn't consider 1.0.0-rc10 to be an update for 1.0.0-rc9.

@cijothomas
Copy link
Member

Agree. Will keep this mind for next releases.
(alternatively, never do more than 9 rcs/betas/alphas 😄 )

@cijothomas cijothomas added the infra Infra work - CI/CD, code coverage, linters label Mar 8, 2022
@cijothomas cijothomas self-assigned this Mar 8, 2022
@cijothomas cijothomas added this to the 1.2.0 milestone Mar 8, 2022
@cijothomas
Copy link
Member

For the instrumentation packages, we can now start using 1.0.0-rc9.1,1.0.0-rc9.2,... etc.
1.0.0-rc10 can be unlisted from nuget as it'll be misleading.

1.2 Release
for core packages, we can continue with the current pattern for 1.2 release (i.e 1.2.0-rc1,...1.2.0-rc7 etc The 1.2 stable is coming soon and we dont anticipate rc count to hit 10).

Post 1.2 Release
for core packages, starting with 1.3, we can do 1.3.0-alpha.1, 1.3.0-beta.1, 1.3.0-beta.2, 1.3.0-rc.1, 1.3.0-rc.2, ...1.3.0-rc.11, ... 1.3.0

@cijothomas
Copy link
Member

For the instrumentation packages, we can now start using 1.0.0-rc9.1,1.0.0-rc9.2,... etc. 1.0.0-rc10 can be unlisted from nuget as it'll be misleading.

1.2 Release for core packages, we can continue with the current pattern for 1.2 release (i.e 1.2.0-rc1,...1.2.0-rc7 etc The 1.2 stable is coming soon and we dont anticipate rc count to hit 10).

Post 1.2 Release for core packages, starting with 1.3, we can do 1.3.0-alpha.1, 1.3.0-beta.1, 1.3.0-beta.2, 1.3.0-rc.1, 1.3.0-rc.2, ...1.3.0-rc.11, ... 1.3.0

This is done.
1.2.0-rc4 of core packages released.
1.0.0-rc9.1 of non core packages released.
1.0.0-rc10 of non packages unlisted from nuget.

Closing this issue - if any further issues, please open a new one.

@paule96
Copy link

paule96 commented Apr 2, 2022

@cijothomas

Sorry for the notification. It was just the issue that 1.9 and 1.9.1 are not the same packages... So I just reread the sample and applied the changes and now it's working.

this release looks a bit unstable. I get with the new packages in my Programm.cs the following error:
image

It complains this on that lines:

builder.Services.AddOpenTelemetryMetrics(builder =>
{
    builder.AddAspNetCoreInstrumentation();
    builder.AddHttpClientInstrumentation();
    builder.AddOtlpExporter(options =>
    {
        options.Endpoint = new Uri("http://otel-collector:4317");
    });
});

@glucaci
Copy link
Contributor Author

glucaci commented Apr 5, 2022

There is no 1.9 or 1.9.1 version, it's only 1.0.0-rc9.1 for non-core packages and 1.2.0-rc4 for core packages.

Make sure that you update all the packages. Seams that is a version incompatibility.
MetricReaderType was removed in 1.2.0-rc4 https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.2.0-rc4

@tillig
Copy link
Contributor

tillig commented Apr 6, 2022

(For future readers...) This happens because the semver pre-release tag is sorted alphabetically rather than numerically. It's convenient that -alpha sorts alphabetically before -beta and that -rc follows, but -rc9 sorts alphabetically after -rc10 which is why it shows up later.

The .NET Core team also has accidentally hit this - early in the .NET Core days (back when the command line was still dnx and projects were going to be JSON format) they also did this -rc9 and -rc10 sort of thing and upgrades failed for a while.

In SemVer 2 they added a concept of "comparing each dot separated identifier from left to right" which I don't think was there at the time. Dots are more significant in delimiting numeric from alphabetic segments than they once were.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

No branches or pull requests

5 participants