Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage can be confusing #2926

Closed
cijothomas opened this issue Feb 22, 2022 · 2 comments · Fixed by #2930
Closed

Code coverage can be confusing #2926

cijothomas opened this issue Feb 22, 2022 · 2 comments · Fixed by #2930
Labels
help wanted Good for taking. Extra help will be provided by maintainers infra Infra work - CI/CD, code coverage, linters

Comments

@cijothomas
Copy link
Member

Originally from here:
#2915 (comment)

Copying the content:

The current code coverage result is not stable (each run will have slightly different results) and is not considered as a blocker for the PR.
I guess the codecov issue could either be related to the tool itself (e.g. some bug, although I think it's less likely to be the case) or the how the test cases were designed (e.g. some test cases require RPC interactions or some other operations that are sensitive to timing/race).

Given this is not the first time folks asked about this, I'm thinking - maybe for short term we should change the codecov CI so it only shows the coverage percentage but always return Success? In this way it still serves the purpose of giving us a rough estimation of the test coverage, but won't introduce confusion to the contributors? https://github.com/orgs/open-telemetry/teams/dotnet-approvers https://github.com/orgs/open-telemetry/teams/dotnet-maintainers what do you think?

@cijothomas cijothomas added the infra Infra work - CI/CD, code coverage, linters label Feb 22, 2022
@cijothomas
Copy link
Member Author

Discussed on 2/22/22 SIG meeting, and we agree to do the below suggestion:

maybe for short term we should change the codecov CI so it only shows the coverage percentage but always return Success?

Any volunteers to help achieve this?

@cijothomas cijothomas added the help wanted Good for taking. Extra help will be provided by maintainers label Feb 22, 2022
@cijothomas
Copy link
Member Author

@eddynaka checking if you have some cycles to help here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Good for taking. Extra help will be provided by maintainers infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant