Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up workflows and test projects after .NET6.0 GA #2563

Closed
vishweshbankwar opened this issue Nov 4, 2021 · 0 comments · Fixed by #2913
Closed

Clean up workflows and test projects after .NET6.0 GA #2563

vishweshbankwar opened this issue Nov 4, 2021 · 0 comments · Fixed by #2913
Assignees
@vishweshbankwar
Labels
enhancement New feature or request
Milestone
1.2.0

Comments

@vishweshbankwar
Copy link
Member

  1. To enable .NET6.0 build, manual installation step for .NET6.0 SDK had to be added as the SDK is not available yet on windows-latest and ubuntu-latest runners. Once the runners have pre-installed version available, we can remove manual installation step.

  2. Following Test Projects have RC package versions referenced: Once GA versions are available, we need to update the references.

  • TestApp.AspNetCore..6.0
  • OpenTelemetry.Exporter.Prometheus.Tests
  • OpenTelemetry.Instrumentation.AspNetCore.Tests

Need to update System.Diagnostic.DiagnosticSource package version as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishweshbankwar vishweshbankwar

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Revert .net6.0 explicit installs vishweshbankwar/opentelemetry-dotnet
2 participants
@cijothomas @vishweshbankwar