From 279595c38a6816382b267a7ee630382db0c9e750 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Kie=C5=82kowicz?= Date: Thu, 7 Mar 2024 07:03:41 +0100 Subject: [PATCH] PR feedback - changelog --- src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md | 4 ++-- src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md index 944adab0c9..df9d719183 100644 --- a/src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md @@ -2,8 +2,8 @@ ## Unreleased -* `server.port` attribute is set even if it has default values (`80` for `HTTP` - and `443` for `HTTPS` protocol). +* Fixed an issue when `server.port` attribute was not set with `server.address` + when it has default values (`80` for `HTTP` and `443` for `HTTPS` protocol). ([#5419](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5419)) ## 1.7.1 diff --git a/src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md index 52b95fbda0..9b7fa69f2f 100644 --- a/src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md @@ -2,8 +2,9 @@ ## Unreleased -* `server.port` attribute is set even if it has default values (`80` for `HTTP` - and `443` for `HTTPS` protocol). +* Fixed an issue for spans when `server.port` attribute was not set with + `server.address` when it has default values (`80` for `HTTP` and + `443` for `HTTPS` protocol). ([#5419](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5419)) ## 1.7.1