Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extendibility via plugins #117

Closed
RassK opened this issue Apr 7, 2021 · 3 comments · Fixed by #129
Closed

Extendibility via plugins #117

RassK opened this issue Apr 7, 2021 · 3 comments · Fixed by #129
Assignees

Comments

@RassK
Copy link
Contributor

RassK commented Apr 7, 2021

Why

Distro providers should have more simpler ways to build up their own distro. Full fork is hard to manage and keep in sync.

What

Introduce plugin architecture for extendibility. Plugins could reside in /plugins folder where dlls can be dynamically loaded.

This feature is connected to: #118

@pellared
Copy link
Member

pellared commented Apr 7, 2021

We need to agree on what extension points are needed.

For Splunk, we need to be able to add additional (or modify existing) HTTP response headers for HTTP Inbound instrumentation.

Maybe we should start with this one?

@pellared
Copy link
Member

pellared commented Apr 7, 2021

Instead of

Plugins could reside in /plugins folder where dlls can be dynamically loaded.

I would prefer to add some env var like OTEL_DOTNET_INSTR_PLUGINS. Requiring to explicitly set it is more secure. It also gives the user to use different plugins for different application. It also makes it possible to harden the location where the plugin resides (e.g. aggressively restrict access to it as potential place where a malicious user could inject some sniffer).

@pellared
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants