From cf3574ee875df31f46745bf4b79d3a77048d3a46 Mon Sep 17 00:00:00 2001 From: Lalit Bhasin Date: Tue, 24 Aug 2021 14:24:54 -0700 Subject: [PATCH 1/3] document default_span, remove default_tracer --- .../opentelemetry/trace/default_span.h | 6 +++ .../opentelemetry/trace/default_tracer.h | 38 ------------------- 2 files changed, 6 insertions(+), 38 deletions(-) delete mode 100644 api/include/opentelemetry/trace/default_tracer.h diff --git a/api/include/opentelemetry/trace/default_span.h b/api/include/opentelemetry/trace/default_span.h index 57785e633c..6ede04c67f 100644 --- a/api/include/opentelemetry/trace/default_span.h +++ b/api/include/opentelemetry/trace/default_span.h @@ -10,6 +10,12 @@ OPENTELEMETRY_BEGIN_NAMESPACE namespace trace { + +/** + * Defaultspan provides a non-operational Span that propogates + * the tracer context by wrapping inside the Span object. + */ + class DefaultSpan : public Span { public: diff --git a/api/include/opentelemetry/trace/default_tracer.h b/api/include/opentelemetry/trace/default_tracer.h deleted file mode 100644 index 8b00e60079..0000000000 --- a/api/include/opentelemetry/trace/default_tracer.h +++ /dev/null @@ -1,38 +0,0 @@ -// Copyright The OpenTelemetry Authors -// SPDX-License-Identifier: Apache-2.0 - -#pragma once -#include "opentelemetry/nostd/unique_ptr.h" -#include "opentelemetry/trace/default_span.h" -#include "opentelemetry/trace/span.h" -#include "opentelemetry/trace/tracer.h" - -OPENTELEMETRY_BEGIN_NAMESPACE -namespace trace -{ -class DefaultTracer : public Tracer -{ -public: - ~DefaultTracer() = default; - - /** - * Starts a span. - * - * Optionally sets attributes at Span creation from the given key/value pairs. - * - * Attributes will be processed in order, previous attributes with the same - * key will be overwritten. - */ - nostd::unique_ptr StartSpan(nostd::string_view name, - const common::KeyValueIterable &attributes, - const StartSpanOptions &options = {}) override noexcept - { - return nostd::unique_ptr(new DefaultSpan::GetInvalid()); - } - - void ForceFlushWithMicroseconds(uint64_t timeout) override noexcept {} - - void CloseWithMicroseconds(uint64_t timeout) override noexcept {} -}; -} // namespace trace -OPENTELEMETRY_END_NAMESPACE From f998dfaf4fe56136d5773ffc3708eb15b6fac489 Mon Sep 17 00:00:00 2001 From: Lalit Bhasin Date: Tue, 24 Aug 2021 14:26:55 -0700 Subject: [PATCH 2/3] fix class name --- api/include/opentelemetry/trace/default_span.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/include/opentelemetry/trace/default_span.h b/api/include/opentelemetry/trace/default_span.h index 6ede04c67f..88ed2ab424 100644 --- a/api/include/opentelemetry/trace/default_span.h +++ b/api/include/opentelemetry/trace/default_span.h @@ -12,8 +12,8 @@ namespace trace { /** - * Defaultspan provides a non-operational Span that propogates - * the tracer context by wrapping inside the Span object. + * DefaultSpan provides a non-operational Span that propogates + * the tracer context by wrapping it inside the Span object. */ class DefaultSpan : public Span From eba40b92af98ee7016a9939214aa948c7faf3f23 Mon Sep 17 00:00:00 2001 From: Lalit Bhasin Date: Tue, 24 Aug 2021 14:38:12 -0700 Subject: [PATCH 3/3] spell --- api/include/opentelemetry/trace/default_span.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/include/opentelemetry/trace/default_span.h b/api/include/opentelemetry/trace/default_span.h index 88ed2ab424..6755704291 100644 --- a/api/include/opentelemetry/trace/default_span.h +++ b/api/include/opentelemetry/trace/default_span.h @@ -12,7 +12,7 @@ namespace trace { /** - * DefaultSpan provides a non-operational Span that propogates + * DefaultSpan provides a non-operational Span that propagates * the tracer context by wrapping it inside the Span object. */