Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trace SDK] - Add SpanExporter#ForceFlush as required method #1623

Closed
lalitb opened this issue Sep 21, 2022 · 1 comment · Fixed by #2000
Closed

[Trace SDK] - Add SpanExporter#ForceFlush as required method #1623

lalitb opened this issue Sep 21, 2022 · 1 comment · Fixed by #2000
Assignees
Labels

Comments

@lalitb
Copy link
Member

lalitb commented Sep 21, 2022

As part of open-telemetry/opentelemetry-specification#2654, ForceFlush was added as required method for SpanExporter. This needs to be added to otel-cpp SDK, possibly with default empty implementation to ensure it's not breaking change for external exporters. Also, if required, the method should be overridden in the core exporters e.g, OTLP HTTP exporter running in Async Mode may need special handling to flush the pending events.

@lalitb lalitb added area:exporter spec-compliance Not compliant to OpenTelemetry specs trace labels Sep 21, 2022
@lalitb lalitb self-assigned this Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Jan 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2023
@lalitb lalitb added do-not-stale and removed Stale labels Jan 9, 2023
@lalitb lalitb reopened this Jan 9, 2023
@owent owent self-assigned this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants