Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Metric view should use instrument name. #1510

Closed
sam-leitch-oxb opened this issue Jul 21, 2022 · 0 comments · Fixed by #1515
Closed

Default Metric view should use instrument name. #1510

sam-leitch-oxb opened this issue Jul 21, 2022 · 0 comments · Fixed by #1515
Assignees
@esigo
Labels
bug Something isn't working metrics
Milestone
Metrics SDK - Rel...

Comments

@sam-leitch-oxb
Copy link

According to the description of Views in the Metrics SDK the name of default views should be the name of the instrument they represent.

According to the code (and unit tests), the views are using the name "otel-default-view"
@sam-leitch-oxb sam-leitch-oxb added the bug Something isn't working label Jul 21, 2022
@lalitb lalitb added the metrics label Jul 21, 2022
@esigo esigo self-assigned this Jul 24, 2022
@esigo esigo mentioned this issue Jul 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esigo esigo

Labels
bug Something isn't working metrics
Projects
None yet
Milestone
Metrics SDK - Release Candidate
Development

Successfully merging a pull request may close this issue.

Fix default Metric view name esigo/opentelemetry-cpp
3 participants
@lalitb @esigo @sam-leitch-oxb