Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Validate number of consumers in exporterhelper #8629

Merged

Conversation

rapphil
Copy link
Contributor

@rapphil rapphil commented Oct 6, 2023

Description: Validate number of consumers in exporterhelper

This is a very small bug fix that does not even deserve a changelog entry. The collector will not work if a queue with a number of consumers <= 0 is used, so we should fail loudly instead of just hanging not draining the data from the queue.

Testing: UTs were added.

Please delete paragraphs that you did not use before submitting.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
exporter/exporterhelper/queue_sender.go 94.78% <100.00%> (+0.13%) ⬆️

📢 Thoughts on this report? Let us know!.

@bogdandrutu bogdandrutu merged commit ffedebe into open-telemetry:main Oct 6, 2023
@github-actions github-actions bot added this to the next release milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants