Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace func obsreport.NewExporter() *Exporter with func obsreport.NewExporter() (*Exporter, error) #6458

Closed
bogdandrutu opened this issue Nov 1, 2022 · 0 comments
Closed

Replace func obsreport.NewExporter() *Exporter with func obsreport.NewExporter() (*Exporter, error) #6458

bogdandrutu opened this issue Nov 1, 2022 · 0 comments
Assignees
@paivagustavo
Labels
Stale

Comments

@bogdandrutu
Copy link
Member

Similar change for all types (Receiver/Processor/etc.)

  1. First PR deprecate the current func and add a new one MustNewExporter
  2. After 1 release and all the usages changed in contrib, replace signature for obsreport.NewExporter and "undeprecate" it and deprecate Must version (if we don't want to keep it).
  3. Remove Must version if we don't want to keep it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paivagustavo paivagustavo

Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bogdandrutu @paivagustavo