From 0d86dc598558eab63e9e25d3a14eb7bc4af06898 Mon Sep 17 00:00:00 2001 From: Curtis Robert Date: Fri, 1 Dec 2023 08:16:48 -0800 Subject: [PATCH 1/2] [chore] Change code owners make command --- CONTRIBUTING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ce68529fc767..4280d037f254 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -379,8 +379,9 @@ Code Ownership is ultimately up to the judgement of the existing Code Owners and To become a Code Owner, open a PR with the following changes: 1. Add your GitHub username to the active codeowners entry in the component's `metadata.yaml` file. -2. Run the command `make gengithub`. This will add your GitHub username to the component's row in the [CODEOWNERS](.github/CODEOWNERS) file. You can do this update manually if the command is unsuccessful. - * Note: A GitHub [personal access token](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens) must be configured for this command to work. +2. Run the command `make update-codeowners`. This will add your GitHub username to the component's row in the [CODEOWNERS](.github/CODEOWNERS) file. + * Note: A GitHub [personal access token](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens) must be configured for this command to work. + * If this command is unsuccessful, manually update the component's row in the [CODEOWNERS](.github/CODEOWNERS) file, and then run `make generate`. Be sure to tag the existing Code Owners, if any, within the PR to ensure they receive a notification. From 0a62458e4eefe34331acad9fc4153984c5ed1156 Mon Sep 17 00:00:00 2001 From: Curtis Robert Date: Fri, 1 Dec 2023 08:20:16 -0800 Subject: [PATCH 2/2] Re-word --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4280d037f254..0dcc5da5899b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -379,9 +379,9 @@ Code Ownership is ultimately up to the judgement of the existing Code Owners and To become a Code Owner, open a PR with the following changes: 1. Add your GitHub username to the active codeowners entry in the component's `metadata.yaml` file. -2. Run the command `make update-codeowners`. This will add your GitHub username to the component's row in the [CODEOWNERS](.github/CODEOWNERS) file. +2. Run the command `make update-codeowners`. * Note: A GitHub [personal access token](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens) must be configured for this command to work. - * If this command is unsuccessful, manually update the component's row in the [CODEOWNERS](.github/CODEOWNERS) file, and then run `make generate`. + * If this command is unsuccessful, manually update the component's row in the [CODEOWNERS](.github/CODEOWNERS) file, and then run `make generate` to regenerate the component's README header. Be sure to tag the existing Code Owners, if any, within the PR to ensure they receive a notification.