Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Owners not being requested for review unless they have write permission #9815

Closed
TylerHelmuth opened this issue May 9, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@TylerHelmuth
Copy link
Member

I noticed today that Code Owners that do not have write permissions (so it seems) to the repository do not get automatically requested for review on PRs for which they are a code owner.
Screen Shot 2022-05-09 at 11 29 28 AM
This PR, for example, probably should have requested review from a lot more people.

Whats strange is that it seems like users only need read access in order for the feature to work. Is the code owners for Contrib setup differently?

@TylerHelmuth TylerHelmuth added the bug Something isn't working label May 9, 2022
@bogdandrutu
Copy link
Member

Nope, this is a known limitation of GH. I also proposed #7063 but the AWS folks seem to not make any progress.

@TylerHelmuth
Copy link
Member Author

@bogdandrutu I want to test something. Just sent you an invite you my fork of contrib.

@TylerHelmuth
Copy link
Member Author

TylerHelmuth commented May 9, 2022

Nvm, my experiment won't work with a fork. I'll test another way.

I have a suspicion that read access is enough, but you have to be explicitly added in the Collaborators and teams section with read access.

@TylerHelmuth
Copy link
Member Author

My suspicion was wrong :( definitely need write access, even as a user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants