Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/transform] Add function parameter validation #9555

Closed
TylerHelmuth opened this issue Apr 27, 2022 · 1 comment · Fixed by #9783
Closed

[processor/transform] Add function parameter validation #9555

TylerHelmuth opened this issue Apr 27, 2022 · 1 comment · Fixed by #9783
Assignees

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Apr 27, 2022

The parser currently always returns an int64 because it doesn't know semantics yet, which is what's passed here. So indeed, validation here would be good - currently the factories return ExprFunc but it seems they should actually be ExprFunc, error

Originally posted by @anuraaga in #9546 (comment)

Functions need to be updated to return ExprFunc, error and should validate parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant